GH-1147 Make UserManager use UserRepository #1147
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CitralFlo
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the UserManager to use a repository pattern for data persistence, which is a great improvement. I've identified a few issues, including a critical bug that causes double database writes and a race condition during initial data loading. Additionally, there are opportunities to improve code clarity and maintainability by simplifying some logic and improving API design. The new integration tests are a good addition, but could be improved by removing console output.
eternalcore-core/src/main/java/com/eternalcode/core/user/UserManager.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/user/UserManager.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/user/UserManager.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/user/database/UserRepository.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/user/database/UserRepository.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/user/database/UserRepositoryOrmLite.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/test/java/com/eternalcode/core/user/BatchTest.java
Outdated
Show resolved
Hide resolved
Jakubk15
reviewed
Aug 31, 2025
eternalcore-core/src/test/java/com/eternalcode/core/user/UserBatchFetchTest.java
Outdated
Show resolved
Hide resolved
sadcenter
reviewed
Aug 31, 2025
eternalcore-core/src/test/java/com/eternalcode/core/user/UserBatchFetchTest.java
Outdated
Show resolved
Hide resolved
sadcenter
approved these changes
Sep 6, 2025
|
|
||
| @Override | ||
| public CompletableFuture<Collection<User>> fetchUsersBatch(int batchSize) { | ||
| return CompletableFuture.supplyAsync(() -> { |
There was a problem hiding this comment.
I think you should supply a custom executor, since you are already using one in all AbstractRepositoryOrmLite methods
…-manager-database
Jakubk15
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods do not change so #1136 can be merged :>